-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Indicate dirty nodes with yellow borders/connectors on canvas #13040
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
|
||
const dirtiness: Record<string, CanvasNodeDirtiness | undefined> = {}; | ||
const visitedByName: Record<string, true | undefined> = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Would using Set
to track visited nodes here be clearer and type-safer?
const visitedByName: Record<string, true | undefined> = {}; | |
const visitedByName = new Set<string>(); |
✅ All Cypress E2E specs passed |
n8n
|
Project |
n8n
|
Branch Review |
sug-2-indicate-dirty-nodes-on-canvas
|
Run status |
|
Run duration | 04m 38s |
Commit |
|
Committer | autologie |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
3
|
|
5
|
|
0
|
|
434
|
View all changes introduced in this branch ↗︎ |
Summary
This PR adds the new feature to highlight edited nodes after an execution with yellow borders/connectors, including its all downstream nodes. This helps user understand which nodes will run when they do a partial execution.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/SUG-2/feature-changing-dirty-nodes-yellow
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)