refactor(core): Move ExecutionLifecycleHooks to core

packages/cli/src/__tests__/workflow-runner.test.ts

@@ -12,17 +12,14 @@ import type {
 	IWorkflowExecutionDataProcess,
 	StartNodeData,
 } from 'n8n-workflow';
-import {
-	Workflow,
-	WorkflowHooks,
-	type ExecutionError,
-	type IWorkflowExecuteHooks,
-} from 'n8n-workflow';
+import { Workflow, type ExecutionError } from 'n8n-workflow';
 import PCancelable from 'p-cancelable';
 
 import { ActiveExecutions } from '@/active-executions';
 import config from '@/config';
+import type { ExecutionEntity } from '@/databases/entities/execution-entity';
 import type { User } from '@/databases/entities/user';
+import type { WorkflowEntity } from '@/databases/entities/workflow-entity';
 import { ExecutionNotFoundError } from '@/errors/execution-not-found-error';
 import { Telemetry } from '@/telemetry';
 import { PermissionChecker } from '@/user-management/permission-checker';
@@ -36,25 +33,14 @@ import { setupTestServer } from '@test-integration/utils';
 
 let owner: User;
 let runner: WorkflowRunner;
-let hookFunctions: IWorkflowExecuteHooks;
 setupTestServer({ endpointGroups: [] });
 
 mockInstance(Telemetry);
 
-class Watchers {
-	workflowExecuteAfter = jest.fn();
-}
-const watchers = new Watchers();
-const watchedWorkflowExecuteAfter = jest.spyOn(watchers, 'workflowExecuteAfter');
-
 beforeAll(async () => {
 	owner = await createUser({ role: 'global:owner' });
 
 	runner = Container.get(WorkflowRunner);
-
-	hookFunctions = {
-		workflowExecuteAfter: [watchers.workflowExecuteAfter],
-	};
 });
 
 afterAll(() => {
@@ -67,6 +53,20 @@ beforeEach(async () => {
 });
 
 describe('processError', () => {
+	let workflow: WorkflowEntity;
+	let execution: ExecutionEntity;
+	let hooks: core.ExecutionLifecycleHooks;
+
+	const watcher = mock<{ workflowExecuteAfter: () => Promise<void> }>();
+
+	beforeEach(async () => {
+		jest.clearAllMocks();
+		workflow = await createWorkflow({}, owner);
+		execution = await createExecution({ status: 'success', finished: true }, workflow);
+		hooks = new core.ExecutionLifecycleHooks('webhook', execution.id, workflow);
+		hooks.addHandler('workflowExecuteAfter', watcher.workflowExecuteAfter);
+	});
+
 	test('processError should return early in Bull stalled edge case', async () => {
 		const workflow = await createWorkflow({}, owner);
 		const execution = await createExecution(
@@ -82,9 +82,9 @@ describe('processError', () => {
 			new Date(),
 			'webhook',
 			execution.id,
-			new WorkflowHooks(hookFunctions, 'webhook', execution.id, workflow),
+			hooks,
 		);
-		expect(watchedWorkflowExecuteAfter).toHaveBeenCalledTimes(0);
+		expect(watcher.workflowExecuteAfter).toHaveBeenCalledTimes(0);
 	});
 
 	test('processError should return early if the error is `ExecutionNotFoundError`', async () => {
@@ -95,9 +95,9 @@ describe('processError', () => {
 			new Date(),
 			'webhook',
 			execution.id,
-			new WorkflowHooks(hookFunctions, 'webhook', execution.id, workflow),
+			hooks,
 		);
-		expect(watchedWorkflowExecuteAfter).toHaveBeenCalledTimes(0);
+		expect(watcher.workflowExecuteAfter).toHaveBeenCalledTimes(0);
 	});
 
 	test('processError should process error', async () => {
@@ -119,9 +119,9 @@ describe('processError', () => {
 			new Date(),
 			'webhook',
 			execution.id,
-			new WorkflowHooks(hookFunctions, 'webhook', execution.id, workflow),
+			hooks,
 		);
-		expect(watchedWorkflowExecuteAfter).toHaveBeenCalledTimes(1);
+		expect(watcher.workflowExecuteAfter).toHaveBeenCalledTimes(1);
 	});
 });