fix(editor): Move overrideButton and other options to the left to line up with container boundary (no-changelog) #13061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
n8n team
mutdmour
approved these changes
Feb 5, 2025
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ADO-3111
|
| Run status |
|
| Run duration | 04m 42s |
| Commit |
|
| Committer | Charlie Kolb |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
433
|
| View all changes introduced in this branch ↗︎ | |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adjust the spacing as the button makes the offset quite unpleasant.
Before:
After:
I'm not actually aware of any textareas that would have a fromAI button, so I adjusted the height via the inspector to reproduce this. (We had the button on the description initially which might have caught this) So this is mostly future-proofing.
ParameterInputadds quite a few custom errors, so an expose seems like the best option here. Happy to change if there's a good alternative though.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-3111/feature-fix-formatting-when-button-is-in-options-and-we-have-a-node
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)