fix(n8n Form Trigger Node): Update error in validateResponseModeConfiguration (no-changelog) #13162
+74
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
n8n team
michael-radency
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
elsmr
reviewed
Feb 10, 2025
| @@ -216,6 +220,19 @@ const validateResponseModeConfiguration = (context: IWebhookFunctions) => { | |||
| }, | |||
| ); | |||
| } | |||
|
|
|||
| if (isRespondToWebhookConnected) { | |||
There was a problem hiding this comment.
Shouldn't this have a version check? If responseMode == 'responseNode' and version is <= 2.1 it would always throw now, no?
There was a problem hiding this comment.
indeed, thanks 🙏
…form-trigger-throws-error-suggesting-a-mode-that-no-longer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update error message in
validateResponseModeConfigurationsince Respond To Webhook node is not supported in version 2.2 and higherRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2301/form-trigger-throws-error-suggesting-a-mode-that-no-longer-exists