Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/n8n 2835 handle error workflows correctly #2705

Conversation

krynble
Copy link
Contributor

@krynble krynble commented Jan 19, 2022

This PR needs to be merged AFTER #2697 as it relies on many changes made by it.

  • Adds runtime checks for the Error workflow feature, where you can select another workflow to be executed upon a workflow error.

This can happen in two different ways:

  1. Select another workflow from the current workflow settings to be executed on error. This secondary workflow needs to contain the Error trigger node
  2. A single workflow contains a trigger path and also the Error trigger node in itself, like self-healing.

The checks were implemented only for situation (1) as (2) doesn't make sense to check ownership for the workflow itself. Also, instance owners bypass this check.

@janober janober added the n8n team Authored by the n8n team label Jan 22, 2022
@krynble
Copy link
Contributor Author

krynble commented Mar 1, 2022

Closing in favor of #2908

@krynble krynble closed this Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants