Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix focus jumping when using chrome autofill #6140

Merged
merged 1 commit into from
May 2, 2023

Conversation

MiloradFilipovic
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@MiloradFilipovic MiloradFilipovic self-assigned this Apr 28, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a72a511) 19.27% compared to head (c16e500) 19.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6140   +/-   ##
=======================================
  Coverage   19.27%   19.27%           
=======================================
  Files        2590     2590           
  Lines      117039   117039           
  Branches    18371    18371           
=======================================
  Hits        22555    22555           
  Misses      93838    93838           
  Partials      646      646           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit c63181b into master May 2, 2023
@MiloradFilipovic MiloradFilipovic deleted the ADO-655-input-focus-fix branch May 2, 2023 08:15
@janober
Copy link
Member

janober commented May 3, 2023

Got released with [email protected]

MiloradFilipovic added a commit that referenced this pull request May 3, 2023
* master:
  feat(JotForm Trigger Node): Add support for hipaa-api.jotform.com (#6171)
  🚀 Release 0.227.0 (#6167)
  fix(editor): Flag issues only on workflow activation (#6127)
  fix(editor): Faster reconnects for push (no-changelog) (#6164)
  fix: Log unhandled errors during license activation (no-changelog) (#6165)
  test: Address flaky setup e2e (no-changelog) (#6085)
  fix(core): Better errors for common status codes fix
  fix(core): Fix bug running addUserActivatedColumn migration on MariaDB (#6157)
  fix: Prevent invocations of 'GET /rest/license' from returning an error when ephemeral licenses are used (#6154)
  fix(editor): Restrict `[empty]` in parameter input hint to zero-length string (#6003)
  fix(core): Assign Unknown Error only if message or description not present in error
  fix(AWS S3 Node): Fix File upload, and add node tests (#6153)
  fix(core): Better error message in Webhook node when using the POST method
  feat(Microsoft Excel 365 Node): Overhaul
  fix(core): Remove SAML config metadataUrl if XML metadata is set directly (#6143)
  ci: Restore load options methods validation (no-changelog) (#6148)
  feat(core): Add notice to alert users a new version is available
  fix(core): Fix canceled execution status (#6142)
  ci: Expand ESLint to tests in BE packages (no-changelog) (#6147)
  fix(editor): Fix focus jumping when using chrome autofill (#6140)
MiloradFilipovic added a commit that referenced this pull request May 3, 2023
…rce-mapper-ui-P2

* feature/resource-mapping-component:
  feat(JotForm Trigger Node): Add support for hipaa-api.jotform.com (#6171)
  🚀 Release 0.227.0 (#6167)
  fix(editor): Flag issues only on workflow activation (#6127)
  fix(editor): Faster reconnects for push (no-changelog) (#6164)
  fix: Log unhandled errors during license activation (no-changelog) (#6165)
  test: Address flaky setup e2e (no-changelog) (#6085)
  fix(core): Better errors for common status codes fix
  fix(core): Fix bug running addUserActivatedColumn migration on MariaDB (#6157)
  fix: Prevent invocations of 'GET /rest/license' from returning an error when ephemeral licenses are used (#6154)
  fix(editor): Restrict `[empty]` in parameter input hint to zero-length string (#6003)
  fix(core): Assign Unknown Error only if message or description not present in error
  fix(AWS S3 Node): Fix File upload, and add node tests (#6153)
  fix(core): Better error message in Webhook node when using the POST method
  feat(Microsoft Excel 365 Node): Overhaul
  fix(core): Remove SAML config metadataUrl if XML metadata is set directly (#6143)
  ci: Restore load options methods validation (no-changelog) (#6148)
  feat(core): Add notice to alert users a new version is available
  fix(core): Fix canceled execution status (#6142)
  ci: Expand ESLint to tests in BE packages (no-changelog) (#6147)
  fix(editor): Fix focus jumping when using chrome autofill (#6140)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants