-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix comment create with assignee ID (repair field name) #906
Merged
janober
merged 1 commit into
n8n-io:master
from
vvvictor07:feature/fix-clickup-comment-create
Aug 31, 2020
Merged
🐛 Fix comment create with assignee ID (repair field name) #906
janober
merged 1 commit into
n8n-io:master
from
vvvictor07:feature/fix-clickup-comment-create
Aug 31, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks a lot. Got merged. |
spam-n-eggs
pushed a commit
to dominion-solutions/n8n
that referenced
this pull request
Sep 2, 2020
* Add Custom S3 Endpoint credentials * Add support for custom S3 endpoint in AWS S3 node * Add support for custom endpoint URL scheme (both HTTP and HTTPS) * Create generic S3 node * Revert AWS S3 node to its original state * ⚡ Add allowUnauthorizedCerts to Postgres-Node * ⚡ Added RAW data option for assets, entries, content types * ⚡ Fixed Contentful error parsing, added missing comma in entryDescription * ⚡ Minor improvements to Contentful-Node * 🐛 Do not overwrite accept header if set on HTTP Request Node * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n * 🔖 Release [email protected] * 🐛 Add missing rawBody for "application/x-www-form-urlencoded" * 🔖 Release [email protected] * 🐛 Fix bug that workflows did not get activated correctly * 🔖 Release [email protected] * ⚡ Add search operation to Zendesk-Node (n8n-io#900) * 🐛 Fix wrong authentication name (n8n-io#908) * 🐛 Fix comment create with assignee ID (repair field name) (n8n-io#906) * 🐛 Fix another wrong property on ClickUp-Node * 👷 Automatically run tslint * 👕 Fix lint issue * ⬆️ Set [email protected] on n8n-node-dev * 📚 Update copy and add information (n8n-io#910) * Update README.md * Update README.md * Update CONTRIBUTING.md * ✨ Add MQTT Trigger-Node (n8n-io#885) * Improvements to MQTT-node * ⚡ Small improvements done * ⚡ Improvements Co-authored-by: LEE SANG JUN <[email protected]> * ⚡ Minor improvements to MQTT Trigger-Node * ⚡ Update buffer code to not get deprecation message * Remove code duplication * Trim whitespaces in AWS credentials * Trim whitespaces in the AWS credentials in other nodes * ⚡ Minor improvements to S3-Node * 📚 Fix link to docker images * ✨ Recursive listing for FTP/SFTP (n8n-io#903) * ⚡ Add allowUnauthorizedCerts to Postgres-Node * ⚡ Added recursive directory listing for SFTP * ⚡ Added recursive listing for FTP * Removed unused imports * ⚡ Fixed creating an instance of both ftp/sftp both regardless of which is used Co-authored-by: Jan Oberhauser <[email protected]> * ⚡ Normalize FTP-Data Co-authored-by: Denis Palashevskii <[email protected]> Co-authored-by: Jan Oberhauser <[email protected]> Co-authored-by: Rupenieks <[email protected]> Co-authored-by: Ricardo Espinoza <[email protected]> Co-authored-by: vvvictor07 <[email protected]> Co-authored-by: Tanay Pant <[email protected]> Co-authored-by: LEE SANG JUN <[email protected]> Co-authored-by: Rupenieks <[email protected]>
spam-n-eggs
pushed a commit
to dominion-solutions/n8n
that referenced
this pull request
Sep 2, 2020
* Add Custom S3 Endpoint credentials * Add support for custom S3 endpoint in AWS S3 node * Add support for custom endpoint URL scheme (both HTTP and HTTPS) * Create generic S3 node * Revert AWS S3 node to its original state * ⚡ Add allowUnauthorizedCerts to Postgres-Node * ⚡ Added RAW data option for assets, entries, content types * ⚡ Fixed Contentful error parsing, added missing comma in entryDescription * ⚡ Minor improvements to Contentful-Node * 🐛 Do not overwrite accept header if set on HTTP Request Node * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n * 🔖 Release [email protected] * 🐛 Add missing rawBody for "application/x-www-form-urlencoded" * 🔖 Release [email protected] * 🐛 Fix bug that workflows did not get activated correctly * 🔖 Release [email protected] * ⚡ Add search operation to Zendesk-Node (n8n-io#900) * 🐛 Fix wrong authentication name (n8n-io#908) * 🐛 Fix comment create with assignee ID (repair field name) (n8n-io#906) * 🐛 Fix another wrong property on ClickUp-Node * 👷 Automatically run tslint * 👕 Fix lint issue * ⬆️ Set [email protected] on n8n-node-dev * 📚 Update copy and add information (n8n-io#910) * Update README.md * Update README.md * Update CONTRIBUTING.md * ✨ Add MQTT Trigger-Node (n8n-io#885) * Improvements to MQTT-node * ⚡ Small improvements done * ⚡ Improvements Co-authored-by: LEE SANG JUN <[email protected]> * ⚡ Minor improvements to MQTT Trigger-Node * ⚡ Update buffer code to not get deprecation message * Remove code duplication * Trim whitespaces in AWS credentials * Trim whitespaces in the AWS credentials in other nodes * ⚡ Minor improvements to S3-Node * 📚 Fix link to docker images * ✨ Recursive listing for FTP/SFTP (n8n-io#903) * ⚡ Add allowUnauthorizedCerts to Postgres-Node * ⚡ Added recursive directory listing for SFTP * ⚡ Added recursive listing for FTP * Removed unused imports * ⚡ Fixed creating an instance of both ftp/sftp both regardless of which is used Co-authored-by: Jan Oberhauser <[email protected]> * ⚡ Normalize FTP-Data * ✨ Add Customer.io-Node (n8n-io#833) * 🚧 Descriptions, node function, generic function changes * ✅ Finished functionality, added icon * ⚡ Added new campaign operations, acommodated for 2 different authentications * ⚡ Fixed number defaults not being numbers but empty strings * ⚡ Some improvements to Customer.io Node * 🐛 Fixed multiple labelIds not working on message -> getAll (n8n-io#916) * 🐛 Fix Label-ID field Co-authored-by: Denis Palashevskii <[email protected]> Co-authored-by: Jan Oberhauser <[email protected]> Co-authored-by: Rupenieks <[email protected]> Co-authored-by: Ricardo Espinoza <[email protected]> Co-authored-by: vvvictor07 <[email protected]> Co-authored-by: Tanay Pant <[email protected]> Co-authored-by: LEE SANG JUN <[email protected]> Co-authored-by: Rupenieks <[email protected]>
Got released with [email protected] |
spam-n-eggs
added a commit
to dominion-solutions/n8n
that referenced
this pull request
Sep 4, 2020
* Added pull.yaml file to .github folder for wei/pull * Added pull.yaml file to .github folder for wei/pull * Update pull.yml * [pull] master from n8n-io:master (#2) * Add Custom S3 Endpoint credentials * Add support for custom S3 endpoint in AWS S3 node * Add support for custom endpoint URL scheme (both HTTP and HTTPS) * Create generic S3 node * Revert AWS S3 node to its original state * ⚡ Add allowUnauthorizedCerts to Postgres-Node * ⚡ Added RAW data option for assets, entries, content types * ⚡ Fixed Contentful error parsing, added missing comma in entryDescription * ⚡ Minor improvements to Contentful-Node * 🐛 Do not overwrite accept header if set on HTTP Request Node * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n * 🔖 Release [email protected] * 🐛 Add missing rawBody for "application/x-www-form-urlencoded" * 🔖 Release [email protected] * 🐛 Fix bug that workflows did not get activated correctly * 🔖 Release [email protected] * ⚡ Add search operation to Zendesk-Node (n8n-io#900) * 🐛 Fix wrong authentication name (n8n-io#908) * 🐛 Fix comment create with assignee ID (repair field name) (n8n-io#906) * 🐛 Fix another wrong property on ClickUp-Node * 👷 Automatically run tslint * 👕 Fix lint issue * ⬆️ Set [email protected] on n8n-node-dev * 📚 Update copy and add information (n8n-io#910) * Update README.md * Update README.md * Update CONTRIBUTING.md * ✨ Add MQTT Trigger-Node (n8n-io#885) * Improvements to MQTT-node * ⚡ Small improvements done * ⚡ Improvements Co-authored-by: LEE SANG JUN <[email protected]> * ⚡ Minor improvements to MQTT Trigger-Node * ⚡ Update buffer code to not get deprecation message * Remove code duplication * Trim whitespaces in AWS credentials * Trim whitespaces in the AWS credentials in other nodes * ⚡ Minor improvements to S3-Node * 📚 Fix link to docker images * ✨ Recursive listing for FTP/SFTP (n8n-io#903) * ⚡ Add allowUnauthorizedCerts to Postgres-Node * ⚡ Added recursive directory listing for SFTP * ⚡ Added recursive listing for FTP * Removed unused imports * ⚡ Fixed creating an instance of both ftp/sftp both regardless of which is used Co-authored-by: Jan Oberhauser <[email protected]> * ⚡ Normalize FTP-Data Co-authored-by: Denis Palashevskii <[email protected]> Co-authored-by: Jan Oberhauser <[email protected]> Co-authored-by: Rupenieks <[email protected]> Co-authored-by: Ricardo Espinoza <[email protected]> Co-authored-by: vvvictor07 <[email protected]> Co-authored-by: Tanay Pant <[email protected]> Co-authored-by: LEE SANG JUN <[email protected]> Co-authored-by: Rupenieks <[email protected]> * [pull] master from n8n-io:master (#3) * Add Custom S3 Endpoint credentials * Add support for custom S3 endpoint in AWS S3 node * Add support for custom endpoint URL scheme (both HTTP and HTTPS) * Create generic S3 node * Revert AWS S3 node to its original state * ⚡ Add allowUnauthorizedCerts to Postgres-Node * ⚡ Added RAW data option for assets, entries, content types * ⚡ Fixed Contentful error parsing, added missing comma in entryDescription * ⚡ Minor improvements to Contentful-Node * 🐛 Do not overwrite accept header if set on HTTP Request Node * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n * 🔖 Release [email protected] * 🐛 Add missing rawBody for "application/x-www-form-urlencoded" * 🔖 Release [email protected] * 🐛 Fix bug that workflows did not get activated correctly * 🔖 Release [email protected] * ⚡ Add search operation to Zendesk-Node (n8n-io#900) * 🐛 Fix wrong authentication name (n8n-io#908) * 🐛 Fix comment create with assignee ID (repair field name) (n8n-io#906) * 🐛 Fix another wrong property on ClickUp-Node * 👷 Automatically run tslint * 👕 Fix lint issue * ⬆️ Set [email protected] on n8n-node-dev * 📚 Update copy and add information (n8n-io#910) * Update README.md * Update README.md * Update CONTRIBUTING.md * ✨ Add MQTT Trigger-Node (n8n-io#885) * Improvements to MQTT-node * ⚡ Small improvements done * ⚡ Improvements Co-authored-by: LEE SANG JUN <[email protected]> * ⚡ Minor improvements to MQTT Trigger-Node * ⚡ Update buffer code to not get deprecation message * Remove code duplication * Trim whitespaces in AWS credentials * Trim whitespaces in the AWS credentials in other nodes * ⚡ Minor improvements to S3-Node * 📚 Fix link to docker images * ✨ Recursive listing for FTP/SFTP (n8n-io#903) * ⚡ Add allowUnauthorizedCerts to Postgres-Node * ⚡ Added recursive directory listing for SFTP * ⚡ Added recursive listing for FTP * Removed unused imports * ⚡ Fixed creating an instance of both ftp/sftp both regardless of which is used Co-authored-by: Jan Oberhauser <[email protected]> * ⚡ Normalize FTP-Data * ✨ Add Customer.io-Node (n8n-io#833) * 🚧 Descriptions, node function, generic function changes * ✅ Finished functionality, added icon * ⚡ Added new campaign operations, acommodated for 2 different authentications * ⚡ Fixed number defaults not being numbers but empty strings * ⚡ Some improvements to Customer.io Node * 🐛 Fixed multiple labelIds not working on message -> getAll (n8n-io#916) * 🐛 Fix Label-ID field Co-authored-by: Denis Palashevskii <[email protected]> Co-authored-by: Jan Oberhauser <[email protected]> Co-authored-by: Rupenieks <[email protected]> Co-authored-by: Ricardo Espinoza <[email protected]> Co-authored-by: vvvictor07 <[email protected]> Co-authored-by: Tanay Pant <[email protected]> Co-authored-by: LEE SANG JUN <[email protected]> Co-authored-by: Rupenieks <[email protected]> * Fixing ClockifTrigger.node.ts to return Co-authored-by: Ethan Sowell <[email protected]> Co-authored-by: Mark Horninger <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Denis Palashevskii <[email protected]> Co-authored-by: Jan Oberhauser <[email protected]> Co-authored-by: Rupenieks <[email protected]> Co-authored-by: Ricardo Espinoza <[email protected]> Co-authored-by: vvvictor07 <[email protected]> Co-authored-by: Tanay Pant <[email protected]> Co-authored-by: LEE SANG JUN <[email protected]> Co-authored-by: Rupenieks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As doc says assignee field name should be
assignee
instead ofassigneeId