Replace all std with alloc except for std::error::Error #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabijaczleweli
commented
Jul 5, 2019
| #[macro_export] | ||
| macro_rules! try_copy { | ||
| ($res:expr) => {{ | ||
| use std::borrow::Cow; | ||
| use $crate::alloc::borrow::Cow; // TODO: There *has* to be a better way of doing this, right? (also below) |
There was a problem hiding this comment.
Is there a better way of doing this? Nothing I'd thought of worked :v
Enet4
requested changes
Jul 8, 2019
There was a problem hiding this comment.
This needs to pass when built with only the alloc feature, so we can start with that.
- Remember that
Vecneeds to be imported manually withalloc.
#[cfg(feature = "alloc")]
use alloc::vec::Vec;no_stdwithallocalready providescore, so theextern cratemust be conditioned onstdrather thanalloc
#[cfg(feature = "std")]
extern crate core;- The tests need to define a global allocator under these conditions. This might require a nightly toolchain.
…d no_std{,+alloc} build systems to Sublime project
Coulda sworn this built for me but maybe I fucked up the switches
Ref: #59
|
Ah, yeah, I must've used the wrong arguments when testing previously. The doctests say error now, too, and before any of them get compiled, but they still pass, so false negative? |
Enet4
approved these changes
Jul 8, 2019
|
Released in v0.11.0-rc.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With only one hiccup!
Closes #58