Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ValueError: invalid domain name" when using IPv6 #675

Closed
astrajeriu opened this issue Nov 6, 2024 · 2 comments
Closed

"ValueError: invalid domain name" when using IPv6 #675

astrajeriu opened this issue Nov 6, 2024 · 2 comments

Comments

@astrajeriu
Copy link

   * SSLyze version: 6.0.0
   * Server: 0:0:0:0:0:0:0:1:4433 - ::1
   * Scan command: ScanCommand.CERTIFICATE_INFO

   Traceback (most recent call last):
     File "/usr/local/lib/python3.11/dist-packages/sslyze/scanner/_mass_scanner.py", line 279, in _generate_result_for_completed_server_scan
scan_cmd_result = plugin_implementation_cls.result_for_completed_scan_jobs(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File "/usr/local/lib/python3.11/dist-packages/sslyze/plugins/certificate_info/implementation.py", line 141, in result_for_completed_scan_jobs
analysis_result = deployment_analyzer.perform()
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File "/usr/local/lib/python3.11/dist-packages/sslyze/plugins/certificate_info/_cert_chain_analyzer.py", line 191, in perform
path_validation_result = trust_store.verify_certificate_chain(
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File "/usr/local/lib/python3.11/dist-packages/sslyze/plugins/certificate_info/trust_stores/trust_store.py", line 83, in verify_certificate_chain
verifier = builder.build_server_verifier(DNSName(server_hostname))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ValueError: invalid domain name

For the same server, when running against 127.0.0.1:4433, there are no running issues

@DavidJuanes
Copy link

Same here - had to downgrade to 5.1.3 to get IPv6 functionality working

@nabla-c0d3 nabla-c0d3 moved this to Backlog in SSLyze 6.1.0 Dec 21, 2024
@nabla-c0d3 nabla-c0d3 changed the title IPv6 compatibility ValueError: invalid domain name when using IPv6 Jan 2, 2025
@nabla-c0d3 nabla-c0d3 changed the title ValueError: invalid domain name when using IPv6 "ValueError: invalid domain name" when using IPv6 Jan 2, 2025
@nabla-c0d3 nabla-c0d3 moved this from Backlog to In progress in SSLyze 6.1.0 Jan 2, 2025
@nabla-c0d3 nabla-c0d3 moved this from In progress to Done in SSLyze 6.1.0 Jan 2, 2025
@nabla-c0d3 nabla-c0d3 closed this as completed by moving to Done in SSLyze 6.1.0 Jan 2, 2025
@nabla-c0d3 nabla-c0d3 reopened this Jan 2, 2025
@nabla-c0d3
Copy link
Owner

Fixed in v6.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants