Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add linux/arm64 to docker build workflow (#648) #655

Conversation

gostega
Copy link
Contributor

@gostega gostega commented Jun 24, 2024

@@ -39,7 +39,7 @@ jobs:
with:
context: ./
file: ./Dockerfile
platforms: linux/amd64
platforms: linux/amd64, linux/arm64

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the only change needed for this to work. If you follow the instructions in the link posted in the description above, you'll notice the chapter describing QEMU setup, that the buildx step possibly needs to succeed in the runner. (See https://docs.docker.com/build/building/multi-platform/ for general info…) — My guess is that at least docker/setup-qemu-action to register the emulation types would be needed…?

@nabla-c0d3 nabla-c0d3 changed the base branch from release to dev December 24, 2024 17:40
@nabla-c0d3 nabla-c0d3 merged commit 5130801 into nabla-c0d3:dev Dec 26, 2024
@nabla-c0d3
Copy link
Owner

Thanks - I just merged it. No idea if this will work tho...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants