Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go client is not show in the service subscription list #142

Merged
merged 3 commits into from
Oct 25, 2020
Merged

Fix go client is not show in the service subscription list #142

merged 3 commits into from
Oct 25, 2020

Conversation

mark4z
Copy link
Contributor

@mark4z mark4z commented Oct 24, 2020

Fixes #141

Subscribe may be called when PushRecevier is initialling.

So initial it first then listening asynchronously.

@binbin0325 binbin0325 changed the title fix Subscribe fail Fix go client is not show in the service subscription list Oct 25, 2020
@lzp0412
Copy link
Collaborator

lzp0412 commented Oct 25, 2020

LGTM

@binbin0325 binbin0325 merged commit fb45465 into nacos-group:master Oct 25, 2020
@binbin0325
Copy link
Member

@mark4z Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binbin0325 binbin0325 binbin0325 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subscriber list query does not have data
3 participants
@mark4z @lzp0412 @binbin0325