Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: server config support custom grpc port #456

Merged
merged 5 commits into from
May 8, 2022

Conversation

zcong1993
Copy link

close #455

@zcong1993
Copy link
Author

ci format 错误是之前别的提交引起的

Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI问题可以帮忙解决下

@zcong1993
Copy link
Author

CI问题可以帮忙解决下

done

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

❗ No coverage uploaded for pull request base (2.0.0@0c9b6a1). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             2.0.0     #456   +/-   ##
========================================
  Coverage         ?   31.91%           
========================================
  Files            ?       37           
  Lines            ?     2663           
  Branches         ?        0           
========================================
  Hits             ?      850           
  Misses           ?     1752           
  Partials         ?       61           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c9b6a1...219663e. Read the comment docs.

.github/workflows/go.yml Outdated Show resolved Hide resolved
common/constant/config.go Outdated Show resolved Hide resolved
@zcong1993 zcong1993 requested a review from binbin0325 April 30, 2022 08:08
.github/workflows/go.yml Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
@zcong1993 zcong1993 requested a review from binbin0325 May 1, 2022 10:42
Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zcong1993
Copy link
Author

@sanxun0325 这个pr什么时候可以合并呢?

@binbin0325 binbin0325 merged commit e7d2324 into nacos-group:2.0.0 May 8, 2022
@binbin0325
Copy link
Member

@sanxun0325 这个pr什么时候可以合并呢?

thank you for your contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants