Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add switch for log stdout #489

Merged

Conversation

chenzfp
Copy link
Contributor

@chenzfp chenzfp commented Jul 17, 2022

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2022

Codecov Report

Merging #489 (66c75b2) into master (24e67a3) will increase coverage by 0.11%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
+ Coverage   51.00%   51.11%   +0.11%     
==========================================
  Files          25       25              
  Lines        2100     2107       +7     
==========================================
+ Hits         1071     1077       +6     
- Misses        940      941       +1     
  Partials       89       89              
Impacted Files Coverage Δ
common/constant/client_config_options.go 87.83% <0.00%> (-3.72%) ⬇️
common/logger/logger.go 87.50% <33.33%> (-2.83%) ⬇️
clients/config_client/config_client.go 47.02% <100.00%> (+0.16%) ⬆️
clients/naming_client/naming_client.go 59.48% <100.00%> (+0.20%) ⬆️
clients/naming_client/beat_reactor.go 84.74% <0.00%> (+6.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24e67a3...66c75b2. Read the comment docs.

@binbin0325
Copy link
Member

thanks for your contribution

@binbin0325 binbin0325 merged commit c7dfb75 into nacos-group:master Jul 17, 2022
@chenzfp chenzfp deleted the feature_bugfix-dubbogo-issue1960 branch July 17, 2022 07:57
@binbin0325 binbin0325 changed the title bugfix dubbo-go issue: nacos-go-sdk stdout redirect #1960 add switch for log stdout Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants