Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ConnectionEvent capacity #588

Merged
merged 1 commit into from
Mar 15, 2023
Merged

update ConnectionEvent capacity #588

merged 1 commit into from
Mar 15, 2023

Conversation

binbin0325
Copy link
Member

fix: #587 , #587

@wangdongyun
Copy link
Contributor

wangdongyun commented Mar 14, 2023 •
edited
Loading

eventChan: make(chan ConnectionEvent, math.MaxInt32),
这里没有问题，消除了死锁的一个条件，
reconenctChan 我建议长度等于1，并且设置为非阻塞的写入，因为 request 失败，会向reconenctChan 写入数据

image
image

@binbin0325 binbin0325 merged commit 802920d into nacos-group:master Mar 15, 2023
@wangdongyun
Copy link
Contributor

make(chan ConnectionEvent, math.MaxInt32) 这里会不会一下子分配 超大的空间

@zhjdhx
Copy link

zhjdhx commented Mar 17, 2023

make(chan ConnectionEvent, math.MaxInt32) 这里会不会一下子分配 超大的空间

已经踩坑，standlone模式，连续开启两个客户端订阅同一个配置，内存直接爆掉了

@wangdongyun
Copy link
Contributor

那就是有问题的

@luluxiu
Copy link

luluxiu commented Jun 25, 2024

make(chan ConnectionEvent, math.MaxInt32) 这里会不会一下子分配 超大的空间

我也踩坑了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[naming 模块] connection 恢复后，注册的实例没有恢复
4 participants
@binbin0325 @wangdongyun @zhjdhx @luluxiu