Master sync java enhancement #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KomachiSion
commented
May 25, 2023
KomachiSion
commented
- Set success as True when ack push success.
- Same as java client, default close async update service by query.
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #617 +/- ##
==========================================
- Coverage 30.66% 30.09% -0.57%
==========================================
Files 40 40
Lines 3059 3060 +1
==========================================
- Hits 938 921 -17
- Misses 2055 2072 +17
- Partials 66 67 +1
☔ View full report in Codecov by Sentry. |
binbin0325
reviewed
May 25, 2023
| @@ -77,7 +77,9 @@ func NewNamingClient(nc nacos_client.INacosClient) (*NamingClient, error) { | |||
|
|
|||
| naming.serviceProxy, err = NewNamingProxyDelegate(ctx, clientConfig, serverConfig, httpAgent, naming.serviceInfoHolder) | |||
|
|
|||
| go NewServiceInfoUpdater(ctx, naming.serviceInfoHolder, clientConfig.UpdateThreadNum, naming.serviceProxy).asyncUpdateService() | |||
| if clientConfig.AsyncUpdateService { | |||
There was a problem hiding this comment.
Java2.1版本加了开关，默认是打开， 2.2开关默认是关闭的。
后续应该这个逻辑会保留，通过开关打开。
binbin0325
approved these changes
May 26, 2023
binbin0325
approved these changes
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.