Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test failed of logger package. #734

Merged
merged 1 commit into from
May 6, 2024

Conversation

wangjian-pg
Copy link
Contributor

image

Unit test of packagelogger failed since PR #722 merged.

It's kind of weird that a PR that failed the unit test can be merged😂...

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.58%. Comparing base (389f6b6) to head (7a248da).
Report is 1 commits behind head on master.

❗ Current head 7a248da differs from pull request most recent head d30fe56. Consider uploading reports for the commit d30fe56 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
- Coverage   32.69%   32.58%   -0.12%     
==========================================
  Files          45       45              
  Lines        3294     3296       +2     
==========================================
- Hits         1077     1074       -3     
- Misses       2136     2140       +4     
- Partials       81       82       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binbin0325 binbin0325 merged commit 163ee14 into nacos-group:master May 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants