Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: env_first when get props from ClientProps. #199

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

CherishCai
Copy link
Collaborator

No description provided.

@CherishCai CherishCai added the enhancement New feature or request label Sep 27, 2023
@CherishCai CherishCai requested a review from onewe September 27, 2023 12:56
@CherishCai CherishCai self-assigned this Sep 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (89b2111) 15.89% compared to head (b71fdef) 15.96%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   15.89%   15.96%   +0.07%     
==========================================
  Files          49       49              
  Lines        2838     2875      +37     
==========================================
+ Hits          451      459       +8     
- Misses       2387     2416      +29     
Files Coverage Δ
src/config/mod.rs 0.00% <0.00%> (ø)
src/lib.rs 56.41% <25.00%> (+3.63%) ⬆️
src/naming/mod.rs 0.00% <0.00%> (ø)
src/config/worker.rs 0.00% <0.00%> (ø)
src/api/props.rs 26.76% <17.39%> (-15.35%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@onewe
Copy link
Collaborator

onewe commented Sep 29, 2023

LGTM

@onewe onewe merged commit 1301c9b into main Sep 29, 2023
@CherishCai CherishCai deleted the enhance_env_first_get_props branch May 16, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants