Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace map_or_else with unwrap_or and add a test for get_value_u32 #212

Merged

Conversation

Mmh-zxz
Copy link
Contributor

@Mmh-zxz Mmh-zxz commented Jan 14, 2024

Replace map_or_else with unwrap_or and add a test for get_value_u32

@CherishCai CherishCai added the chore Chore for code label Jan 14, 2024
Copy link
Collaborator

@CherishCai CherishCai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, pls cargo fmt --all

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (dbf4917) 15.95% compared to head (991a45b) 15.88%.

Files Patch % Lines
src/lib.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   15.95%   15.88%   -0.07%     
==========================================
  Files          49       49              
  Lines        2871     2864       -7     
==========================================
- Hits          458      455       -3     
+ Misses       2413     2409       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CherishCai CherishCai merged commit 75bee4f into nacos-group:main Jan 14, 2024
5 checks passed
@Mmh-zxz Mmh-zxz deleted the replace-map_or_else-with-unwrap_or branch January 14, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore for code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants