Metrics Cleanup: Fix pvc allocated space reporting and pvc size at creation time. #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will set 'ready for review' once my latest eve update completes test |
Allocated space is only available from lh volume object status. PVC should be created with app inst vol defined size not img. Set FileLocation in Populate() so its published automatically. Fix missing VolumeStatus after modifying in volumemgr/AppDiskMetrics. Signed-off-by: Andrew Durbin <[email protected]>
andrewd-zededa
force-pushed
the
csi-handler-details-allocatedSpace
branch
from
5399dfd to
7ca4294
Compare
|
Latest push just removed the commented out block of code in RolloutDiskToPVC |
|
How did the testing go ? |
|
@zedi-pramodh app instance metrics look stable now and show proper thin allocation percentages. |
|
Great I will merge it then. |
zedi-pramodh
merged commit 1b46a77
into
naiming-zededa:poc-oct03-2024
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allocated space is only available from lh volume object status.
PVC should be created with app inst vol defined size not img.
Set FileLocation in Populate() so its published automatically.
Fix missing VolumeStatus after modifying in volumemgr/AppDiskMetrics.
Shorter timeout set in k8s api calls for metrics path.