Make it possible to parse issues

go.mod

@@ -4,6 +4,7 @@ go 1.14
 
 require (
 	github.com/gdamore/tcell v1.3.0
+	github.com/golangci/golangci-lint v1.26.0
 	github.com/rivo/tview v0.0.0-20200414130344-8e06c826b3a5
 	github.com/shibukawa/configdir v0.0.0-20170330084843-e180dbdc8da0
 	github.com/sirupsen/logrus v1.5.0

main.go

@@ -9,7 +9,7 @@ import (
 
 func main() {
 	// TODO: Populate
-	appConfig, err := config.New("", "", "", "", "", false)
+	appConfig, err := config.New("", "", "", "", "", "", false)
 	if err != nil {
 		log.Fatal(err.Error())
 	}

pkg/app/app.go

@@ -6,6 +6,7 @@ import (
 	"github.com/sirupsen/logrus"
 
 	"github.com/nakabonne/golintui/pkg/config"
+	"github.com/nakabonne/golintui/pkg/golangcilint"
 	"github.com/nakabonne/golintui/pkg/gui"
 )
 
@@ -21,11 +22,12 @@ type App struct {
 }
 
 func New(conf *config.Config) (*App, error) {
+	runner := golangcilint.NewRunner(conf.Executable, []string{})
 	return &App{
 		closers: []io.Closer{},
 		Config:  conf,
 		Log:     newLogger(conf),
-		Gui:     gui.New(),
+		Gui:     gui.New(runner),
 	}, nil
 }
 

pkg/config/config.go

@@ -1,5 +1,7 @@
 package config
 
+const defaultExecutable = "golangci-lint"
+
 // Config includes the base configuration fields required for golintui.
 type Config struct {
 	Name        string
@@ -8,19 +10,26 @@ type Config struct {
 	Commit      string
 	BuildDate   string
 	BuildSource string
+
+	// Path to a golangci-lint executable.
+	Executable string
 	// UserConfig    *viper.Viper
 	// UserConfigDir string
 	// IsNewRepo bool
 }
 
-func New(name, version, commit, date, buildSource string, debuggingFlag bool) (*Config, error) {
+func New(name, version, commit, date, buildSource, executable string, debuggingFlag bool) (*Config, error) {
+	if executable == "" {
+		executable = defaultExecutable
+	}
 	return &Config{
 		Name:        "",
 		Debug:       false,
 		Version:     "",
 		Commit:      "",
 		BuildDate:   "",
 		BuildSource: "",
+		Executable:  executable,
 	}, nil
 }
 

pkg/golangcilint/issue.go

@@ -0,0 +1,18 @@
+package golangcilint
+
+import (
+	"github.com/golangci/golangci-lint/pkg/result"
+)
+
+// Issue is a wrapper of the issue model represented golangci-lint internally.
+type Issue struct {
+	issue *result.Issue
+}
+
+func NewIssues(issues []result.Issue) []Issue {
+	res := make([]Issue, 0, len(issues))
+	for _, i := range issues {
+		res = append(res, Issue{issue: &i})
+	}
+	return res
+}

pkg/golangcilint/linter.go

@@ -0,0 +1,6 @@
+package golangcilint
+
+type Linter struct {
+	Name    string
+	Enabled bool
+}

pkg/golangcilint/runner.go

@@ -1,22 +1,68 @@
 package golangcilint
 
-import "github.com/nakabonne/golintui/pkg/config"
+import (
+	"encoding/json"
+	"os/exec"
+
+	"github.com/golangci/golangci-lint/pkg/printers"
+
+	"github.com/nakabonne/golintui/pkg/config"
+)
 
 const globOperator = "/..."
 
 type Runner struct {
+	// Path to a golangci-lint executable.
+	Executable string
 	// Args given to `golangci-lint run`.
 	// An arg can be a file name, a dir, and in addition,
 	// `...` to analyze them recursively.
 	Args   []string
 	Config *config.Config
+
+	// dir specifies the working directory.
+	dir string
 }
 
-func NewRunner(args []string) *Runner {
+func NewRunner(executable string, args []string) *Runner {
 	// TODO: Automatically read config from golangci settings file.
-	return &Runner{Args: args, Config: &config.Config{}}
+	return &Runner{
+		Executable: executable,
+		Args:       args,
+		Config:     &config.Config{},
+		dir:        ".",
+	}
 }
 
 func (r *Runner) AddArgs(arg string) {
 	r.Args = append(r.Args, arg+globOperator)
 }
+
+// Run executes `golangci-lint run` with its own args and configuration.
+func (r *Runner) Run(arg string) ([]Issue, error) {
+	outJSON, err := r.execute("run", true, r.Args...)
+	if err != nil {
+		return nil, err
+	}
+
+	var res printers.JSONResult
+	if err := json.Unmarshal(outJSON, &res); err != nil {
+		return nil, err
+	}
+	return NewIssues(res.Issues), nil
+}
+
+func (r *Runner) ListLinters() []Linter {
+	// TODO: First up, run `golangci-lint run --out-format=json` against safety dir.
+	//   And then fetch linters from Report.Linters.
+	return []Linter{}
+}
+
+func (r *Runner) execute(subCommand string, outJSON bool, args ...string) ([]byte, error) {
+	if outJSON {
+		args = append(args, "--out-format=json")
+	}
+	cmd := exec.Command(r.Executable, args...)
+	cmd.Dir = r.dir
+	return cmd.CombinedOutput()
+}

pkg/gui/gui.go

@@ -22,14 +22,14 @@ type Gui struct {
 	runner *golangcilint.Runner
 }
 
-func New() *Gui {
+func New(runner *golangcilint.Runner) *Gui {
 	return &Gui{
 		application:     tview.NewApplication(),
 		lintersItem:     item.NewLinters(),
 		sourceFilesItem: item.NewSourceFiles("."),
 		resultsItem:     item.NewResults(),
 		infoItem:        item.NewInfo(),
-		runner:          golangcilint.NewRunner([]string{}),
+		runner:          runner,
 	}
 }