Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure to re-use TCP connection #14

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Ensure to re-use TCP connection #14

merged 2 commits into from
Nov 11, 2020

Conversation

nakabonne
Copy link
Owner

Fixes: #6

@codecov-io
Copy link

codecov-io commented Nov 11, 2020

Codecov Report

Merging #14 (85d28fd) into main (c1b5a2f) will decrease coverage by 8.60%.
The diff coverage is 6.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   43.72%   35.12%   -8.59%     
==========================================
  Files          10       10              
  Lines         501      504       +3     
==========================================
- Hits          219      177      -42     
- Misses        238      289      +51     
+ Partials       44       38       -6     
Impacted Files Coverage Δ
agent/agent.go 42.50% <0.00%> (-18.25%) ⬇️
diagnoser/diagnoser.go 38.89% <17.65%> (-1.49%) ⬇️
stats/stats.go 0.00% <0.00%> (-88.23%) ⬇️
stats/meta.go 34.79% <0.00%> (-56.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b5a2f...85d28fd. Read the comment docs.

@nakabonne nakabonne merged commit 3ab239a into main Nov 11, 2020
@nakabonne nakabonne deleted the reuse-conn branch November 11, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reuse connections instead of creating each time
2 participants