Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Write Ahead Log #28

Merged
merged 7 commits into from
Oct 28, 2021
Merged

Add support for Write Ahead Log #28

merged 7 commits into from
Oct 28, 2021

Conversation

nakabonne
Copy link
Owner

@nakabonne nakabonne commented Jul 21, 2021

Fixes #5

This PR adds support for WAL only for insertOperation. The format is:

	   +--------+---------------------+--------+--------------------+----------------+
	   | op(1b) | len metric(varints) | metric | timestamp(varints) | value(varints) |
	   +--------+---------------------+--------+--------------------+----------------+

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #28 (f3bcf01) into main (2ad4f71) will decrease coverage by 3.34%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   66.08%   62.74%   -3.33%     
==========================================
  Files          19       19              
  Lines         955     1111     +156     
==========================================
+ Hits          631      697      +66     
- Misses        229      288      +59     
- Partials       95      126      +31     
Impacted Files Coverage Δ
memory_partition.go 81.68% <33.34%> (-1.65%) ⬇️
storage.go 52.23% <46.52%> (-3.86%) ⬇️
disk_wal.go 51.05% <51.05%> (ø)
wal.go 50.00% <60.00%> (-50.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f08788...f3bcf01. Read the comment docs.

@nakabonne nakabonne force-pushed the add-file-wal branch 12 times, most recently from 9ebb30e to 3f3c2d0 Compare October 19, 2021 01:52
@nakabonne nakabonne marked this pull request as ready for review October 28, 2021 01:38
@nakabonne nakabonne changed the title Support Write Ahead Log Add support for Write Ahead Log Oct 28, 2021
@nakabonne nakabonne merged commit e7ef1a5 into main Oct 28, 2021
@nakabonne nakabonne deleted the add-file-wal branch October 28, 2021 01:48
@github-actions github-actions bot mentioned this pull request Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support WAL to offer durability guarantees
2 participants