Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix #14

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Minor fix #14

merged 4 commits into from
Dec 12, 2024

Conversation

nanasess
Copy link
Owner

This pull request includes several changes aimed at improving code quality, consistency, and functionality. The most important changes include adding a new configuration file for PHP-CS-Fixer, updating dependencies, and making various code improvements across multiple files.

Configuration and Dependencies:

  • Added a new PHP-CS-Fixer configuration file .php-cs-fixer.dist.php to enforce coding standards and rules.
  • Updated composer.json to include friendsofphp/php-cs-fixer as a development dependency.

Code Improvements:

  • Replaced count function calls with \count for better performance and consistency in src/Command/GenerateDummyDataCommand.php and tests/Fixture/Generator.php. [1] [2]
  • Updated the constructor in GenerateDummyDataCommand to accept nullable strings.
  • Added missing namespace references to various method calls in tests/Fixture/Generator.php. [1] [2]

Minor Fixes:

  • Changed class_exists to class_exists in bootstrap.php for consistency.
  • Added missing commas and corrected formatting in tests/Fixture/Generator.php. [1] [2]

@nanasess nanasess merged commit c41cb84 into main Dec 12, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant