Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't enable done flag with text. #123

Merged
merged 1 commit into from
May 23, 2014
Merged

Don't enable done flag with text. #123

merged 1 commit into from
May 23, 2014

Conversation

take-cheeze
Copy link
Contributor

I thought LeaveMessage inherits TextMessage but its base was actually Message.
So text must be set manually after creating leave message.

@take-cheeze
Don't enable done flag with text.
c4624a0 
Set text after creating leave message.
jgable added a commit that referenced this pull request May 23, 2014
@jgable
Merge pull request #123 from take-cheeze/leave_msg_fix
4046fa4 
Don't enable done flag with text.
@jgable jgable merged commit 4046fa4 into nandub:master May 23, 2014
@jgable
Copy link
Collaborator

jgable commented May 23, 2014

Published as 0.2.6.

@take-cheeze
Copy link
Contributor Author

Thanks for the merge. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@take-cheeze @jgable