Prevent election winner from being immediately reinserted into AEC #4313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
force-pushed
the
fix-aec-confirmed-race
branch
from
c17cf7a to
1f69bc0
Compare
…oesn't need to be evaluated when debugging is off.
clemahieu
approved these changes
Oct 11, 2023
|
I believe that there is nothing left to do with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test
active_transactions.inactive_votes_cache_forktest is failing intermittently because of an AEC race condition. The problem is that is possible that a block that won an election will be immediately reinserted into the AEC. There is no way to atomically switch election to confirmed state and register it as recently confirmed, so this PR minimizes the chance of that happening. I think in this case the design tries to be too smart to the point of being impossible to implement with full correctness.