Fixed bug in derived params when OMDOT uncertainty is 0 #1689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1688
Tried to compute Mtot from OMDOT including uncertainty in
fitter.derived_params()
. But in this case OMDOT had no uncertainty since it was afuncParameter
. Now has explicit protection against 0 uncertainties (whether from this or a frozen model).Related question: should the Mtot computation there happen at all if OMDOT < 0?