Component validation for WaveX and DMWaveX #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1702 +/- ##
=======================================
Coverage 68.76% 68.77%
=======================================
Files 105 105
Lines 24642 24644 +2
Branches 4407 4407
=======================================
+ Hits 16946 16948 +2
Misses 6590 6590
Partials 1106 1106 ☔ View full report in Codecov by Sentry. |
abhisrkckl
added
the
awaiting review
|
This looks fine. A test would be nice but probably not crucial. I can merge when you are ready. |
|
Yes. Please merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit warnings when
WaveXis used together withWaveorPLRedNoise.Similarly for
DMWaveX.