Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to configurator impl address #204

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

qshao-gauntlet
Copy link
Collaborator

What?

ie: Add support for uniswap contract events

How?

ie: I used abi-parser or cli tools to build the table definitions

Related PRs (optional)

PRs that are related to this or may need to be deployed before this PR

Anything Else?

@medvedev1088
Copy link
Contributor

I don't think the tables would be populated since the contract doesn't emit any events https://basescan.org/address/0x83e0f742cacbe66349e3701b171ee2487a26e738#events

Here is Polygon for comparison https://polygonscan.com/address/0x83e0f742cacbe66349e3701b171ee2487a26e738#events

@daishuai323
Copy link
Contributor

@qshao-gauntlet Do we still need this PR?

@qshao-gauntlet
Copy link
Collaborator Author

yep, the old address is wrong.

@daishuai323
Copy link
Contributor

@medvedev1088 Could you help check if the address is right? I couldn't find the new address in Compound Base address list here or any emitted events

@medvedev1088
Copy link
Contributor

The new address doesn't exist on Base it seems https://basescan.org/address/0x316f9708bb98af7da9c68c1c3b5e79039cd336e3. But it exists on Ethereum https://etherscan.io/address/0x316f9708bB98af7dA9c68C1C3b5e79039cD336E3#events

From the Compound docs https://docs.compound.finance/ it seems 0x45939657d1CA34A8FA39A924B71D28Fe8431e581 is the configurator address for Base - USDbC Base (Bridged).

@qshao-gauntlet are you trying to query specific events for Compound on Base?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants