replace with view query #233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinja
reviewed
Nov 15, 2023
| @@ -31,7 +31,7 @@ | |||
| "name": "ValidatorConfigSet", | |||
| "type": "event" | |||
| }, | |||
| "contract_address": "SELECT * FROM UNNEST(['0x08f9654349b33b955133b28e35dbecce9950c219', '0x6228a44cd0ec29c3373c9742e4bbaf6f2e536b9a', '0x57d2d46fc7ff2a7142d479f2f59e1e3f95447077', '0x0ee7145e1370653533e2f2e824424be2aa95a4aa'])", | |||
| "contract_address": "SELECT proxy_address FROM ref('view_AccessControlledOffchainAggregator_info')", | |||
There was a problem hiding this comment.
I think they should be contract_address
marcinja
reviewed
Nov 15, 2023
parse/table_definitions_base/chainlink/view_AccessControlledOffchainAggregator_info.sql
Outdated
Show resolved
Hide resolved
|
@qshao-gauntlet GitHub reports there are still conflicts that need to be resolved before merging: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
ie: Add support for uniswap contract events
How?
ie: I used abi-parser or cli tools to build the table definitions
Related PRs (optional)
PRs that are related to this or may need to be deployed before this PR
Anything Else?