Fix error message and default value for status #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround regarding Poetry's bug. If there are two identically constrained version specification, Poetry attempts to resolve dependency versions for every constraints combination, even if there's no intersection, which raises SolverProblemError. This behaviour isn't fixed yet but tracked in <python-poetry/poetry#3367> and will be resolved in <python-poetry/poetry#4695>.
r-yamada1998
requested changes
Mar 28, 2022
|
Installation script |
r-yamada1998
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #506.
The default value for
controller.statushave changed from""toNone.This is not an essential change, but for improvement of readability.
On the other hand, the behaviour of numerous functions which requires controlling authority is changed.
Currently those functions return empty string
""(viadeco_checkdecorator), which causes confusing error messages likeAttributeError: 'str' object has no attribute '**'.This PR proposes such operation to raise a custom error
NECSTAuthorityErrorto give understandable error messages. This can break functions which expect the empty string as a sign for authority error, but such functions should usetry...exceptstatements.