-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow message to match on multiple OS #245
Merged
mirceaulinic
merged 2 commits into
napalm-automation:develop
from
luke-orden:send_to_multiple_os
May 30, 2018
Merged
Allow message to match on multiple OS #245
mirceaulinic
merged 2 commits into
napalm-automation:develop
from
luke-orden:send_to_multiple_os
May 30, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should we stop searching and just return, or should we return all matches OS?napalm-logs/napalm_logs/server.py Lines 174 to 179 in a839c02
This comment was generated by todo based on a
|
This fixes napalm-automation#242 Currently when a matching OS is found we do not check remaining OS. This mean that if 2 OS have message prefixes that match each other's logs then you cannot be sure that the message will be forwarded onto the correct `device` process. I have updated so the message is now forwarded onto all matching os, not just the first match. To allow the tests to work correctly I have removed `'send_raw': True` from the config test.
luke-orden
force-pushed
the
send_to_multiple_os
branch
from
May 29, 2018 11:04
a839c02
to
0c90d6e
Compare
Removed the |
mirceaulinic
requested changes
May 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please fix also the py3 issues so the tests run cleanly:
=================================== FAILURES ===================================
_______________________________________ _______________________________________
napalm_logs/listener/kafka.py:17:1: W0612 local variable 'err' is assigned to but never used [pyflakes]
_______________________________________ _______________________________________
napalm_logs/listener/zeromq.py:16:1: W0612 local variable 'err' is assigned to but never used [pyflakes]
_______________________________________ _______________________________________
napalm_logs/transport/kafka.py:15:1: W0612 local variable 'err' is assigned to but never used [pyflakes]
This fixes the following: ``` =================================== FAILURES =================================== _______________________________________ _______________________________________ napalm_logs/listener/kafka.py:17:1: W0612 local variable 'err' is assigned to but never used [pyflakes] _______________________________________ _______________________________________ napalm_logs/listener/zeromq.py:16:1: W0612 local variable 'err' is assigned to but never used [pyflakes] _______________________________________ _______________________________________ napalm_logs/transport/kafka.py:15:1: W0612 local variable 'err' is assigned to but never used [pyflakes] ```
mirceaulinic
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #242
Currently when a matching OS is found we do not check remaining OS. This
mean that if 2 OS have message prefixes that match each other's logs
then you cannot be sure that the message will be forwarded onto the
correct
device
process.I have updated so the message is now forwarded onto all matching os, not
just the first match.
To allow the tests to work correctly I have removed
'send_raw': True
from the config test.