Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Enable file prompt quiet only once at the beginning when configuration occurs for cisco_ios #893

Closed
vladola opened this issue Dec 21, 2018 · 3 comments
Assignees
Milestone

Comments

@vladola
Copy link

vladola commented Dec 21, 2018

Essentially what @ktbyers described in this comment of issue #879

On your point 1, I think we should just add an attribute to the napalm object where we track the file_prompt_quiet state. Once we change this once, then we set that flag to True. Then in the napalm close() method, if that file_prompt_quiet flag has been set to True, we re-set it back to no file prompt quiet.

Basically since we are making a configuration change to the device, we should only do it if we need to (i.e. we shouldn't do it in open() as then you would be making this config change even for getter operations). But if we do it for config() operations and then just track the state so we only do it once, that would be a big improvement.

I'll give it a go.

@vladola vladola changed the title [Enhancement] Enable file prompt quiet only once at the beginning of a configuration method [Enhancement] Enable file prompt quiet only once at the beginning when configuration occurs for cisco_ios Dec 21, 2018
@mirceaulinic mirceaulinic added this to the APPROVED milestone Dec 23, 2018
@vladola
Copy link
Author

vladola commented Dec 24, 2018

I'll work on this in the new year. 👌

@vladola
Copy link
Author

vladola commented Jan 15, 2019

Starting on this ^ - been some busy days.

@ktbyers
Copy link
Contributor

ktbyers commented Apr 25, 2019

I think this issue was fixed. Related PR here #918

@ktbyers ktbyers closed this as completed Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants