Check if temperature sensor on Cisco device is not supported #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some older Cisco devices like models from the 2960 platform have no temperature sensor built-in. In that case the get_environment function will throw on exception. That case will now be handeled.
1 task
|
See issue 1000 |
1 similar comment
|
Has anyone an idea why four out of six checks fail? Looks like tox isn't working properly. |
mirceaulinic
requested changes
Sep 3, 2019
| @@ -2110,7 +2110,7 @@ def get_environment(self): | |||
| re_temp_value = re.compile("(.*) Temperature Value") | |||
| # The 'show env temperature status' is not ubiquitous in Cisco IOS | |||
| output = self._send_command(temp_cmd) | |||
| if "% Invalid" not in output: | |||
| if "% Invalid" and "Not Supported" not in output: | |||
There was a problem hiding this comment.
I think if "% Invalid" not in output or "Not Supported" not in output: might be what you want.
There was a problem hiding this comment.
@mirceaulinic You are 'more right' than me, but still not entirely correct: It's if "% Invalid" not in output and "Not Supported" not in output: - and instead of or :) I will try to update my PR, not sure how to do that...
|
I branched my repository, so I had to recreate this PR, see #1055. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some older Cisco devices like models from the 2960 platform have no temperature sensor built-in. In that case the get_environment function will throw on exception. That case will now be handeled.