Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firmware less than 7 does not support json in cli #1084

Merged
merged 3 commits into from
Jan 18, 2020
Merged

firmware less than 7 does not support json in cli #1084

merged 3 commits into from
Jan 18, 2020

Conversation

VictorPavlushin
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 81.504% when pulling a5e81ee on VictorPavlushin:serialnum-nxos_ssh-json into c01f351 on napalm-automation:develop.

@coveralls
Copy link

coveralls commented Nov 12, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 81.54% when pulling 2ea3bec on VictorPavlushin:serialnum-nxos_ssh-json into ae0e628 on napalm-automation:develop.

mirceaulinic
mirceaulinic approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks @VictorPavlushin!

@mirceaulinic mirceaulinic mentioned this pull request Nov 12, 2019
Closed
1 task
@mirceaulinic mirceaulinic added this to the 3.0.0 milestone Nov 12, 2019
@mirceaulinic mirceaulinic merged commit 46f7e64 into napalm-automation:develop Jan 18, 2020
neelimapp pushed a commit to neelimapp/napalm that referenced this pull request Mar 20, 2020
@VictorPavlushin @mirceaulinic @neelimapp
firmware less than 7 does not support json (napalm-automation#1084)
4d9fa81 
napalm-automation#1082

Co-authored-by: Mircea Ulinic <[email protected]>
bharath-ravindranath pushed a commit to bharath-ravindranath/napalm that referenced this pull request Apr 19, 2020
@VictorPavlushin @mirceaulinic @bravindranath-bsn
firmware less than 7 does not support json (napalm-automation#1084)
57eb7e6 
napalm-automation#1082

Co-authored-by: Mircea Ulinic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceaulinic mirceaulinic mirceaulinic approved these changes

Assignees
No one assigned
Labels
bug nxos-ssh
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@VictorPavlushin @coveralls @mirceaulinic