Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: traceroute output parsing in ios #1102

Merged
merged 6 commits into from
Jan 18, 2020
Merged

FIX: traceroute output parsing in ios #1102

merged 6 commits into from
Jan 18, 2020

Conversation

realvitya
Copy link
Contributor

traceroute output with AS number parsed wrongly.
This small fix cleans up this:
Example hop parsed wrongly:
1 1.1.1.1 [AS 65200] 40 msec 40 msec 40 msec
string after clean:
1 1.1.1.1 40 msec 40 msec 40 msec

@coveralls
Copy link

coveralls commented Jan 10, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 81.517% when pulling a15fb86 on realvitya:develop into 286667c on napalm-automation:develop.

@mirceaulinic mirceaulinic added this to the 3.0.0 milestone Jan 18, 2020
mirceaulinic
mirceaulinic approved these changes Jan 18, 2020
View reviewed changes
Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirceaulinic mirceaulinic merged commit ae0e628 into napalm-automation:develop Jan 18, 2020
neelimapp pushed a commit to neelimapp/napalm that referenced this pull request Mar 20, 2020
@realvitya @mirceaulinic @neelimapp
FIX: traceroute output parsing in ios (napalm-automation#1102)
81da9d0 
* fix traceroute output parsing

* additional fix for dotted AS format

* fix formatting to satisfy black/pylame

* fix comment

Co-authored-by: Mircea Ulinic <[email protected]>
bharath-ravindranath pushed a commit to bharath-ravindranath/napalm that referenced this pull request Apr 19, 2020
@realvitya @mirceaulinic @bravindranath-bsn
FIX: traceroute output parsing in ios (napalm-automation#1102)
683343b 
* fix traceroute output parsing

* additional fix for dotted AS format

* fix formatting to satisfy black/pylame

* fix comment

Co-authored-by: Mircea Ulinic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceaulinic mirceaulinic mirceaulinic approved these changes

Assignees
No one assigned
Labels
bug ios
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@realvitya @coveralls @mirceaulinic