Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for XML namespace prefixes in find_txt #1141

Merged
merged 3 commits into from
Mar 20, 2020

Conversation

111pontes
Copy link
Contributor

Prefix-name mapping simplifies the use of XPaths with XML namespace references. XPaths may now include references to namespace prefixes. Resolves #1140.

Prefix-name mapping simplifies the use of XPaths with XML namespace
references.  XPaths may now include references to namespace prefixes
instead of entire namespace strings.
Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this patch @111pontes. There's a conflict with a change we've merged in recently, could you take a look please?

@111pontes
Copy link
Contributor Author

We've decided not to rely on find_txt to retrieve values from YANG trees. Therefore, our PR can be ignored if desired. If you still want to have namespace support anyway, let me know and I'll gladly resolve the conflict.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling ed4b26e on 111pontes:helper-find-txt into 31d1c3e on napalm-automation:develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling ed4b26e on 111pontes:helper-find-txt into 31d1c3e on napalm-automation:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling ed4b26e on 111pontes:helper-find-txt into 31d1c3e on napalm-automation:develop.

@mirceaulinic
Copy link
Member

No problem @111pontes - the conflict was easy to resolve. I'm going to merge this regardless, wouldn't hurt having this. Cheers!

@mirceaulinic mirceaulinic merged commit 8deb8b6 into napalm-automation:develop Mar 20, 2020
@mirceaulinic mirceaulinic added this to the 3.0.0 milestone Mar 20, 2020
neelimapp pushed a commit to neelimapp/napalm that referenced this pull request Mar 20, 2020
…#1141)

* Add support for XML namespace prefixes in find_txt

Prefix-name mapping simplifies the use of XPaths with XML namespace
references.  XPaths may now include references to namespace prefixes
instead of entire namespace strings.

* Black format

Co-authored-by: Mircea Ulinic <[email protected]>
bharath-ravindranath pushed a commit to bharath-ravindranath/napalm that referenced this pull request Apr 19, 2020
…#1141)

* Add support for XML namespace prefixes in find_txt

Prefix-name mapping simplifies the use of XPaths with XML namespace
references.  XPaths may now include references to namespace prefixes
instead of entire namespace strings.

* Black format

Co-authored-by: Mircea Ulinic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helper function should support XML namespace prefixes
3 participants