fixing show interfaces summary for 10/40/100 Gig Interfaces #1162
Conversation
|
@mirceaulinic I have uploaded the PR again , but I don't know how to fix the black test.... . |
|
Should I add some test data to |
napalm/ios/ios.py
Outdated
| @@ -1,4 +1,3 @@ | |||
| """NAPALM Cisco IOS Handler.""" | |||
There was a problem hiding this comment.
Please don't remove this line.
I'd suggest adding a separate test case, e.g., under |
test/ios/mocked_data/test_get_interfaces_counters/short_if_names/expected_result.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Getting there @network-shark, just some small corrections then should be ready to get this in. To make sure the tests are passing before pushing new commits, simply install the dev requirements, pip install -r requirements-dev.txt, then run tox from your virtual environment. If that's passing locally, it should make Travis happy as well. :-)
napalm/ios/ios.py
Outdated
|
|
||
| interface_type, interface_number = split_interface(interface) | ||
| if interface_type in [ | ||
| 'HundredGigabitEthernet', |
There was a problem hiding this comment.
Okay, only Black is failing now (seems like it requires double quotes on these): just run black . (in the environment you installed requirements-dev.txt) and should be gtg.
There was a problem hiding this comment.
Thank you for beeing such a help :)
This PR fixes #1154