New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if we are ignoring warnings on commit, also ignore them on discard #1522

Merged

mirceaulinic merged 1 commit into napalm-automation:develop from ekoyle:discard_ignore_warning

Nov 29, 2021

Contributor

ekoyle commented Nov 23, 2021

Make a similar change to #1480 to allow more graceful recovery from expected configuration warnings (see this comment).

The changes in py-junos-eznc pull 1131 are included in junos_eznc-2.6.3 (I'm not sure which version first included the change).


          if we are ignoring warnings, also ignore them on discard

689ab2f

mirceaulinic approved these changes

View reviewed changes

Member

mirceaulinic left a comment

Makes sense to me.

mirceaulinic merged commit 43cdbcc into napalm-automation:develop

mirceaulinic added this to the 3.4.0 milestone

mirceaulinic added junos optional arg discard_config labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discard_config junos optional arg