-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace confparse w netutils #1565
Replace confparse w netutils #1565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except a minor change, this looks good to me.
Deferring to @ktbyers for more input.
LGTM, let's remove that one |
…apalm into replace_confparse_w_netutils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice!
May I ask when napalm could have a release(or a cherry-pick) for this change please? |
@mirceaulinic @ktbyers @jvanderaa - Would you please kindly show the plan when we could have the new release with the feature in this PR? |
The next release depends on when Mircea gets a chance to do it. I think it should be shortly (i.e. in the next few weeks). But the code is there i.e. just git clone the develop branch or git clone to the commit right after this is incorporated i.e. there is nothing stopping you from getting and using the code. |
@ktbyers - Thanks for your information! |
Fixes #1550
This replaces parsing with Netutils to handle parsing of configuration lines.
Testing thus far has been in a separate Python script that will get added as well to the PR. There were no previous tests written for the previous parser, so I found a basic BGP config for the first part to get the section bgp. The second and third configurations are tests with data from Cisco's documentation.
This shows the use cases that have been presented in
ios.py
around BGP parsing and section parsing.