Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylama was broke and not actually executing pycodestyle #1850

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Pylama was broke and not actually executing pycodestyle #1850

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad0943e
Pylama was broke and not actually executing pycodestyle
ktbyers Feb 16, 2023
dbf869d
Merge branch 'develop' into fix_pycodestyle
ktbyers Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion napalm/eos/eos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ def _load_config(self, filename=None, config=None, replace=True):
return None

try:
if not any(l == "end" for l in commands):
if not any(cmd == "end" for cmd in commands):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a linter failure...it didn't like the single-letter variable.

commands.append("end") # exit config mode
if self.eos_autoComplete is not None:
self._run_commands(
Expand Down
4 changes: 2 additions & 2 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ universal = 1
license_file = LICENSE

[pylama]
linters = mccabe,pep8,pyflakes
linters = mccabe,pycodestyle,pyflakes
ignore = D203,C901,E203
skip = .tox/*,.env/*,.venv/*

[pylama:pep8]
[pylama:pycodestyle]
max_line_length = 100

[tool:pytest]
Expand Down