eos: refactor vrf parsing #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bewing
force-pushed
the
issue-1922
branch
11 times, most recently
from
371757e to
0334382
Compare
bewing
commented
May 15, 2023
bewing
force-pushed
the
issue-1922
branch
2 times, most recently
from
502dfbb to
673a1f5
Compare
Add a fixed width table parser to base string utilities. Use the known dashed line to discern field widths of VRF text output. Use those values instead of TextFSM/regex parsing of the output to determine VRF RD and interface assignments.
I believe when I first collected the output for this test case 6 years ago, I didn't actually collect it from a router, and may have just copied an existing text file and edited it manually. This is an issue since we are trying to switch to fixed-width column parsing for the output. I have hand-edited it this time to match the format and spacing of the other test cases, as I do not have access to the router or config that was used as the source for this test case.
If version of EOS is new enough (>= 4.23.0), use the JSON output of "show vrf" to avoid issues with text parsing in 4.28+ Anecdotal evidence suggests that "default" was added to the text output of "show vrf" in 4.23, so this also resolves the double route issue in 1919. closes #1919
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a fixed width table parser to base string utilities. Use the known dashed line to discern field widths of VRF text output. Use those values instead of TextFSM/regex parsing of the output to determine VRF RD and interface assignments.
If EOS version >= 4.23.0, just use the dang json
Resolves #1922 and #1919