EOS add force_cfg_session_invalid argument #1927
Merged
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the abort command is refused, for instance because of a TACACS issue the config_session is never cleared because an exception is raised by self._run_commands. This is an issue in Saltstack case: - a pending session could contain incomplete changes - this pending session is resumed on the next load_config call causing messed up configuration This change ensure the config_session is always cleared.
…/criteo-forks/napalm into clear_session_discard
|
CC: @kpetremann @bewing Slight changes to the previous solution. Do you see any issues? |
|
@ktbyers sure :) actually I was hesitating with try except approach. I just tend to choose the solution with less, but that is only code style 😁 |
|
with less indentation* |
|
Yeah, it is six of one half dozen of the other...we thought this showed in the code when this case would happen a bit clearer (i.e. it is when the discard fails that we need to potentially do this override). |
you are totally right, it is more obvious that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the
self.config_sessionto be invalidated on certain failures (right now adiscard_config()failure).