Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ping functionalty to nxos driver #641

Closed
wants to merge 5 commits into from
Closed

Added ping functionalty to nxos driver #641

wants to merge 5 commits into from

Conversation

mirceaulinic
Copy link
Member

This PR ports @arandomguybr's work from #489 and adds the necessary mocked data for the tests.

@mirceaulinic mirceaulinic added this to the 2.4.0 milestone Feb 7, 2018
@mirceaulinic mirceaulinic requested a review from a team February 7, 2018 09:50
@mirceaulinic mirceaulinic mentioned this pull request Feb 7, 2018
Closed
@coveralls
Copy link

coveralls commented Feb 7, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.08%) to 78.859% when pulling a5c5d27 on port-pr-489 into f32ad84 on develop.

@ktbyers ktbyers requested review from ktbyers and removed request for a team February 7, 2018 18:06
@ktbyers
Copy link
Contributor

ktbyers commented Feb 7, 2018

Restructured to share common code in PR #642

@ktbyers ktbyers closed this Feb 7, 2018
@mirceaulinic mirceaulinic deleted the port-pr-489 branch May 6, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktbyers ktbyers Awaiting requested review from ktbyers

Assignees
No one assigned
Labels
method implementation nxos nxos-ssh
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mirceaulinic @coveralls @ktbyers @arandomguybr