Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #736 #737

Merged
merged 2 commits into from
May 24, 2018
Merged

Fix #736 #737

merged 2 commits into from
May 24, 2018

Conversation

bewing
Copy link
Member

@bewing bewing commented May 22, 2018

Fix #736

@bewing bewing requested review from dbarrosop and mirceaulinic May 22, 2018 18:54
@bewing bewing self-assigned this May 22, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 77.192% when pulling f07bbcd on iss_736 into d80d5d0 on develop.

1 similar comment
@coveralls
Copy link

coveralls commented May 22, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-1.8%) to 77.192% when pulling f07bbcd on iss_736 into d80d5d0 on develop.

@bewing
Copy link
Member Author

bewing commented May 22, 2018

Is coveralls counting mocked data as lines of code?

mirceaulinic
mirceaulinic approved these changes May 23, 2018
View reviewed changes
Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@bewing bewing merged commit 24f887b into develop May 24, 2018
@bewing bewing deleted the iss_736 branch May 24, 2018 15:23
bewing added a commit that referenced this pull request May 24, 2018
@bewing
Merge branch 'develop' into get_route_to_longer
80ad020 
* develop:
  Fix #736 (get_route_to bgp confed) (#737)
ExaneServerTeam pushed a commit to ExaneServerTeam/napalm that referenced this pull request Mar 6, 2020
@bewing @ExaneServerTeam
Fix napalm-automation#736 (get_route_to bgp confed) (napalm-automatio…
5febdb6 
…n#737)

* Add test case for napalm-automation#736

* Strip parans from path when doing remote_as in get_route_to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceaulinic mirceaulinic mirceaulinic approved these changes

@dbarrosop dbarrosop Awaiting requested review from dbarrosop

Assignees

@bewing bewing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bewing @coveralls @mirceaulinic