Fix #732 #738
Merged
Fix #732 #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did anyone besides @bewing test this? I think @mirceaulinic was having the same issue. Did you test? |
xavierhardy
approved these changes
Jul 23, 2018
|
@bewing This PR is still good to go--correct? |
mirceaulinic
approved these changes
Aug 3, 2018
There was a problem hiding this comment.
Unfortunately I didn't have the time to test it myself, but let's get this merged - it looks good. If there's any issue, we can fix it, although I trust @bewing as always he wrote great code.
cspeidel
pushed a commit
to cspeidel/napalm
that referenced
this pull request
Aug 9, 2018
The new heredoc handling code was causing issues with multiline banners that contained bangs (!), as we originally checked first for bang comments before checking for heredoc sections. * Fixes napalm-automation#732
ExaneServerTeam
pushed a commit
to ExaneServerTeam/napalm
that referenced
this pull request
Mar 6, 2020
The new heredoc handling code was causing issues with multiline banners that contained bangs (!), as we originally checked first for bang comments before checking for heredoc sections. * Fixes napalm-automation#732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.