Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

junos: support edit/top keywords in set based configs #760

Merged
merged 4 commits into from
Aug 2, 2018

Conversation

ckishimo
Copy link
Contributor

@ckishimo ckishimo commented Jul 4, 2018

This PR adds support for edit and top keywords in set based configuration in Junos. The edit is used instead of set if one needs to add comments using the annotate statement as you need to be at the right hierarchy level

For instance:

top edit system ntp
annotate peer 1.1.1.1 "Test ntp server"

system {
    ntp {
        /* Test ntp server */
        peer 1.1.1.1;
        peer 2.2.2.2;
    }
}

One cannot add a comment with a single set command

@coveralls
Copy link

coveralls commented Jul 4, 2018

Coverage Status

Coverage remained the same at 78.967% when pulling 79bfbcd on ckishimo:edit into c5e5f60 on napalm-automation:develop.

@ktbyers ktbyers merged commit 322f45b into napalm-automation:develop Aug 2, 2018
cspeidel pushed a commit to cspeidel/napalm that referenced this pull request Aug 9, 2018
@ckishimo ckishimo deleted the edit branch August 8, 2019 12:54
ExaneServerTeam pushed a commit to ExaneServerTeam/napalm that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants