Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOS get_bgp_neighbors check for None type neighbor_entry - Fix #843 #844

Merged
merged 1 commit into from
Oct 25, 2018
Merged

IOS get_bgp_neighbors check for None type neighbor_entry - Fix #843 #844

merged 1 commit into from
Oct 25, 2018

Conversation

jtishey
Copy link
Contributor

@jtishey jtishey commented Oct 25, 2018

For IOS getter get_bgp_neighbors(), if a neighbor shows up with a supported AFI, but no info under that AFI, a ValueError is raised, which causes a TypeError since the neighbor_entry is None. Skipping the neighbor/afi seems like an acceptable solution.

@jtishey jtishey mentioned this pull request Oct 25, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 79.003% when pulling f535482 on jtishey:ios_bgp_neighbor_none into 6d84d61 on napalm-automation:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 79.003% when pulling f535482 on jtishey:ios_bgp_neighbor_none into 6d84d61 on napalm-automation:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 79.003% when pulling f535482 on jtishey:ios_bgp_neighbor_none into 6d84d61 on napalm-automation:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 79.003% when pulling f535482 on jtishey:ios_bgp_neighbor_none into 6d84d61 on napalm-automation:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 79.003% when pulling f535482 on jtishey:ios_bgp_neighbor_none into 6d84d61 on napalm-automation:master.

@mirceaulinic mirceaulinic added this to the 2.3.4 milestone Oct 25, 2018
@mirceaulinic mirceaulinic requested a review from ktbyers October 25, 2018 12:35
mirceaulinic
mirceaulinic approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktbyers ktbyers merged commit cb5d7dd into napalm-automation:master Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceaulinic mirceaulinic mirceaulinic approved these changes

@ktbyers ktbyers Awaiting requested review from ktbyers

Assignees
No one assigned
Labels
bug ios
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jtishey @coveralls @mirceaulinic @ktbyers