Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testing issues on get_users for root user on Junos #868

Merged
merged 21 commits into from
Nov 20, 2018
Merged

Fix testing issues on get_users for root user on Junos #868

merged 21 commits into from
Nov 20, 2018

Conversation

ktbyers
Copy link
Contributor

@ktbyers ktbyers commented Nov 20, 2018 •
edited
Loading

Fixes the tests on this PR:
#608

@sincerywaing

sincerywaing and others added 21 commits January 3, 2018 15:11
@sincerywaing
issue#600
8c9ce5e 
1. add a private method _get_root(self) to specifically handle root user;
2. add a new view 'junos_root_table' for above method.
3. put _get_root() as an embedded method for get_users()
@sincerywaing
issue#600
03173a0 
add new table and view for `_get_root(self)`.
@sincerywaing
add root user mocked data
7a897a7
@sincerywaing
Delete _configuration__system____configuration_.xml
474395e
@sincerywaing
add mocked data for root user
1f86901
@sincerywaing
add root user
d0db178
@sincerywaing
Update _configuration__system____configuration_.xml
39c18f3
@sincerywaing
Update _configuration__system____configuration_.xml
c56893c
@sincerywaing
pre-define privilege 15 for root user.
32e5661
@sincerywaing
Update expected_result.json
15dc3e9
@mirceaulinic
Merge branch 'develop' into issue#napalm-automation#600
e274fd3
@sincerywaing
Merge branch 'develop' into issue#napalm-automation#600
b7734ca
@sincerywaing
Update expected_result.json
2901159
@sincerywaing
Update expected_result.json
3a0b259
@sincerywaing
Merge branch 'develop' into issue#napalm-automation#600
9488d91
@sincerywaing
Update expected_result.json
c49b0e1
@sincerywaing
update root user
28c0394 
assign privilege to 20
@ktbyers
Merge branch 'develop' into issue#napalm-automation#600
27d363e
@sincerywaing
Merge branch 'develop' into issue#napalm-automation#600
6f2d0dd
@ktbyers
Merge branch 'develop' into issue#napalm-automation#600
7186f46
@ktbyers
Fixing test failures
2a276bc
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 80.37% when pulling 2a276bc on ktbyers:sincerywaing-issue600 into 6a32b82 on napalm-automation:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 80.37% when pulling 2a276bc on ktbyers:sincerywaing-issue600 into 6a32b82 on napalm-automation:develop.

@ktbyers ktbyers merged commit 892c3ea into napalm-automation:develop Nov 20, 2018
ExaneServerTeam pushed a commit to ExaneServerTeam/napalm that referenced this pull request Mar 6, 2020
@ktbyers @ExaneServerTeam
Implement get_users for root user on Junos (napalm-automation#868)
b7dc754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceaulinic mirceaulinic mirceaulinic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ktbyers @coveralls @mirceaulinic @sincerywaing