Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_lldp_neighbors_detail function #875

Closed
wants to merge 1 commit into from

Conversation

jnmatlock
Copy link

Added two additional device SWITCH models including EX4300-32F and EX2300-48T.

Added two additional device SWITCH models including EX4300-32F and EX2300-48T.
@ktbyers
Copy link
Contributor

ktbyers commented Dec 6, 2018

Can we switch this to more of a regex-pattern solution (for example, 2300., 4300.)?

By this I mean instead of updating this per exact-model number, update it using a model-pattern where the model-pattern wouldn't care about the number of ports or whether they are powered or not, et cetera.

I am referring here to the entire solution and not just your specific fix.

             'SWITCH': {
                 'default': rpc_call_with_information,
                'EX9208': rpc_call_without_information,
                'EX3400': rpc_call_without_information,
                'EX4300-48P': rpc_call_without_information,
                'EX4300-32F': rpc_call_without_information,
                'EX4600-40F': rpc_call_without_information,
                'QFX5100-48S-6Q': rpc_call_without_information,
                'QFX5110-48S-4C': rpc_call_without_information,
                'QFX10002-36Q': rpc_call_without_information,
                'QFX10008': rpc_call_without_information,
                'EX2300-48T': rpc_call_without_information,
                'EX2300-24P': rpc_call_without_information,
                'EX2300-C-12P': rpc_call_without_information
            },

@jnmatlock
Copy link
Author

Great point. Looking into that, right now.

@ktbyers
Copy link
Contributor

ktbyers commented Dec 6, 2018

Okay, great...yes, I think if we make this a bit more pattern based we can hopefully reduce the amount of churn/updates due to this.

@jobec
Copy link
Contributor

jobec commented Dec 7, 2018

See #876
Instead of just adding yet another model to the list, I propose to automatically handle it, removing the maintenance of this list.

I'll see on opening a PR for this.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.526% when pulling 48c89d9 on jnmatlock:patch-1 into 5811c53 on napalm-automation:develop.

@ktbyers
Copy link
Contributor

ktbyers commented Dec 11, 2018

Obsoleted by #878

@ktbyers ktbyers closed this Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants