Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing remote port in junos LLDP neighbors data #888

Merged
merged 3 commits into from
Dec 20, 2018
Merged

Handle missing remote port in junos LLDP neighbors data #888

merged 3 commits into from
Dec 20, 2018

Conversation

jobec
Copy link
Contributor

@jobec jobec commented Dec 19, 2018 •
edited
Loading

Handle missing remote port in junos LLDP neighbors data.
In case there's no remote port, it'll return None instead of an empty string ""

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.474% when pulling 3cad9ed on jobec:junos_lldp_missing_portid into f5220ea on napalm-automation:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.474% when pulling 3cad9ed on jobec:junos_lldp_missing_portid into f5220ea on napalm-automation:develop.

@coveralls
Copy link

coveralls commented Dec 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 80.231% when pulling cedc34c on jobec:junos_lldp_missing_portid into 5cb82a0 on napalm-automation:develop.

@mirceaulinic mirceaulinic added this to the 2.3.6 milestone Dec 20, 2018
@mirceaulinic mirceaulinic merged commit b54f269 into napalm-automation:develop Dec 20, 2018
@jobec jobec deleted the junos_lldp_missing_portid branch December 21, 2018 19:45
ExaneServerTeam pushed a commit to ExaneServerTeam/napalm that referenced this pull request Mar 6, 2020
@jobec @ExaneServerTeam
Handle missing remote port in junos LLDP neighbors data (napalm-autom…
169e548 
…ation#888)

* Handle missing remote port in junos LLDP neighbors data

* Fix LLDP mock data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceaulinic mirceaulinic mirceaulinic approved these changes

Assignees
No one assigned
Labels
bug junos
Projects
None yet
Milestone
2.3.6
Development

Successfully merging this pull request may close these issues.
4 participants
@jobec @coveralls @mirceaulinic @ktbyers